feat: HLS 세그먼트를 앞부분부터 잘라서 로드시킬 수 있는 커스텀 리소스 로더 구현 #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chopmozzi
approved these changes
Dec 14, 2023
Comment on lines
+64
to
+83
| private func sliceM3U8Playlist(_ m3u8Playlist: String, duration: TimeInterval) -> String { | ||
| var duration = duration | ||
| var playlist = m3u8Playlist.components(separatedBy: M3U8Tag.extinf.rawValue) | ||
| .compactMap { | ||
| if $0.contains(M3U8Tag.extm3u.rawValue) { return $0 } // 시작부분 | ||
| else if let tsDuration = $0.components(separatedBy: ",").compactMap({ Double($0) }).first, | ||
| duration > .zero { | ||
| duration -= tsDuration | ||
| return $0 | ||
| } else { | ||
| return nil | ||
| } | ||
| }.joined(separator: M3U8Tag.extinf.rawValue) | ||
|
|
||
| if !playlist.contains(M3U8Tag.extend.rawValue) { | ||
| playlist.append("\n\(M3U8Tag.extend.rawValue)") | ||
| } | ||
|
|
||
| return playlist | ||
| } |
anyukyung
reviewed
Dec 14, 2023
Comment on lines
+68
to
+76
| if $0.contains(M3U8Tag.extm3u.rawValue) { return $0 } // 시작부분 | ||
| else if let tsDuration = $0.components(separatedBy: ",").compactMap({ Double($0) }).first, | ||
| duration > .zero { | ||
| duration -= tsDuration | ||
| return $0 | ||
| } else { | ||
| return nil | ||
| } | ||
| }.joined(separator: M3U8Tag.extinf.rawValue) |
There was a problem hiding this comment.
pdf로만 봤었는데 m3u8파일 내부를 까서 시작 부분부터 재생할 duration까지만 ts 세그먼트를 합치는 고런 로직이군요.. 좋습니당
There was a problem hiding this comment.
맞아요 간단한...3초 3겹살...
anyukyung
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
네이버 Deview 2021 세션을 참고해서 구현했습니다.
문제가 우리 앱을 실기기 테스트를 해보니 메모리를 평균 27메가 정도로 상당히 적게 먹어서 홈 캐러셀 쪽은 별로 의미가 없는 것 같네요.
나중에 유경님 여유되시면 맵쪽 캐러셀에 적용해보셔서 실험 해보심 어떨까 합니다.
Linked Issue
close #266